[feature] SC-166737/improve app proxy security by restricting where token replacements can go#97
Open
HappyPaul55 wants to merge 2 commits intomainfrom
Conversation
…oken replacements can go
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the proxy configuration security by introducing the settingsInjection field to restrict where sensitive authentication settings can be injected. The changes limit token and credential replacements to specific headers or body fields for each Atlassian API endpoint, reducing potential security vulnerabilities.
Key changes:
- Added
settingsInjectionconfiguration for three Atlassian endpoints to control where credentials can be injected - Reordered proxy whitelist entries (moved auth.atlassian.com to the top)
- Restricted credential injection to specific locations (headers or body) per endpoint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 40a09b7 deployed to: https://jira-pr-97.ci.next.deskprodemo.com URLs: |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the proxy configuration in
manifest.jsonto support dynamic injection of authentication settings for Atlassian API requests. The main change is the addition of thesettingsInjectionfield, which allows sensitive credentials and tokens to be injected into request headers or bodies as needed for different endpoints.Proxy configuration enhancements:
settingsInjectionfor thehttps://auth.atlassian.com/.*endpoint, enabling injection ofclient_idandclient_secretinto the request body, andapi_tokeninto the header.https://(.*).atlassian.net/.*andhttps://api.atlassian.com/.*endpoints to support injection ofapi_keyandusernameinto request headers via the newsettingsInjectionfield.